PAM passwdqc, strict aliasing, and WARNS

[Justin T. Gibbs]

Someone who has yet to confess added -Werror to the global CFLAGS
(via /etc/make.conf) for one of our systems at work.  Before I
figured out that this was the cause of builds failing, I hacked up
pam_passwdc to resolve the problem.  This gets the module to
WARNS=2, but to go farther, the "logically const" issues with this
code will need to be sorted out.

Is this change worth committing?  Is this the best way to resolve
the strict aliasing issues in this code?

Thanks,
Justin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pam_passwdqc.diff
Type: application/octet-stream
Size: 7584 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20120713/df0441b6/pam_passwdqc.obj