couldn't log on to my -CURRENT machine after upgrade to latest
PAM
Dag-Erling Smørgrav
des at des.no
Mon Jan 9 20:25:13 UTC 2012
Don Lewis <truckman at FreeBSD.org> writes:
> After staring at the code a lot more, I see your point about the loss of
> information. The problem is that openpam_parse_chain() returns
> PAM_SUCCESS whether or not if found anything, but we want the loop to
> terminate when either an error is detected or if openpam_parse_chain()
> actually found something. Maybe changing the loop exit to something
> like this would work:
>
> if (ret != PAM_SUCCESS || pamh->chains[facility] != NULL)
> return (ret);
The simplest fix for now is probably to revert r487; it applies cleanly
except for the first hunk, which is easy to apply manually.
DES
--
Dag-Erling Smørgrav - des at des.no
More information about the freebsd-current
mailing list