vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

Attilio Rao attilio at freebsd.org
Sun Nov 20 20:24:02 UTC 2011


2011/11/20 Kostik Belousov <kostikbel at gmail.com>:
> On Sun, Nov 20, 2011 at 08:22:38PM +0100, Attilio Rao wrote:
>> 2011/11/20 Kostik Belousov <kostikbel at gmail.com>:
>> > On Sun, Nov 20, 2011 at 08:04:21PM +0100, Attilio Rao wrote:
>> >> This other patch converts sx to a similar interface which cleans up vm_map.c:
>> >> http://www.freebsd.org/~attilio/sxfileline.patch
>> >>
>> >> What do you think about it?
>> >
>> > This one only changes the KBI ? Note that _sx suffix is not reserved.
>>
>> In which sense?
>> If you want to keep the shim support for KLD (thus the hard path) you
>> will always need to keep an hard function and thus you still need a
>> macro acting as a gate between the 'hard function' (or KLD version, if
>> you prefer) and the fast case, that is where the "_" suffix came from.
>
> As I see, right now kernel exports e.g. _sx_try_slock() for the hard path.
> After the patch, it will export sx_try_slock_() for the same purpose.
> The old modules, which call _sx_try_slock(), cannot be loaded into
> the patched kernel. Am I reading the patch wrong ?

We shouldn't be concerned about it for -CURRENT, when MFCing this
patch I'll just make:

#define sx_try_slock_ _sx_try_slock

rather than renaming the function.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the freebsd-current mailing list