Fix softdep_request_cleanup difference w/ and w/o SOFTUPDATES
Aleksandr Rybalko
ray at ddteam.net
Mon Mar 28 18:04:06 UTC 2011
On Mon, 28 Mar 2011 11:32:12 -0400
Ryan Stone <rysto32 at gmail.com> wrote:
> On Mon, Mar 28, 2011 at 6:19 AM, Aleksandr Rybalko <ray at dlink.ua>
> wrote:
> > Hi,
> >
> > I found a difference of definition softdep_request_cleanup.
> > when SOFTUPDATES undefined softdep_request_cleanup take only two
> > arguments.
> >
> > Patch to fix this:
> >
> > Index: sys/ufs/ffs/ffs_softdep.c
> > ===================================================================
> > --- sys/ufs/ffs/ffs_softdep.c (revision 220095)
> > +++ sys/ufs/ffs/ffs_softdep.c (working copy)
> > @@ -514,9 +514,10 @@
> > }
> >
> > int
> > -softdep_request_cleanup(fs, vp)
> > +softdep_request_cleanup(fs, vp, resource)
> > struct fs *fs;
> > struct vnode *vp;
> > + int resource;
> > {
> >
> > return (0);
>
> If we need to change the definition, shouldn't we convert it to a C89
> declaration at the same time?
Yeah, I agree with you, but think peoples who made nice things for UFS
have they own plan what to do with this.
I only fix problem for building without SOFTUPDATES flag set.
BTW, if someone interest I can convert all declaration of this file to
C89 :)
--
Aleksandr Rybalko <ray at ddteam.net>
More information about the freebsd-current
mailing list