[rfc] removing/conditionalising WERROR= in Makefiles

Chuck Burns break19 at gmail.com
Fri Dec 30 13:25:47 UTC 2011

On 12/30/2011 7:06 AM, Dimitry Andric wrote:
> On 2011-12-26 11:10, Alexander Best wrote:
>> that's why i'd like to propose the following patch. i ran a full
>> tinderbox run
>> against r228878 and it suceeded.
> Did you also try this with clang? For example the xfs module alone gets
> a whole slew of warnings, which would be fatal if WERROR= was removed:
> sys/gnu/fs/xfs/xfs_dir2_block.c:1149:17: warning: array index of '1'
> indexes past the end of an array (that contains 1 element) [-Warray-bounds]
> dep->name[0] = dep->name[1] = '.';
> ^ ~
> sys/gnu/fs/xfs/xfs_dir2_data.h:90:2: note: array 'name' declared here
> __uint8_t name[1]; /* name bytes, no null */
> ^
> 1 warning generated.

just as an aside, the XFS module didn't seem to work when I last 
attempted to use it, so it may be worth just removing it?

Chuck Burns
The Southern Libertarian

More information about the freebsd-current mailing list