Remove debug echo
fjoe at samodelkin.net
Thu Dec 15 08:56:52 UTC 2011
On Thu, Dec 15, 2011 at 10:39 AM, Garrett Cooper <yanegomi at gmail.com> wrote:
>> If someone would please, PLEASE commit this.. I will give you beer, or
> >> wine, or a copy of Skyrim, or a few months subscription to WoW, or
> >> something else of value to you that we could negotiate :)... I'm quite
> >> frankly tired of having to playing guessing games fishing through logs
> >> trying to determine build errors on FreeBSD if and when they do occur
> >> with pmake, and I'm sure that a number of developers and build/release
> >> engineers out there are in the same boat as I am.
> > Can you explain why did you remove MESSAGE() invocations in your patch?
> > Other than that the patch looks good to me.
> I thought that printing out MESSAGE and the more informative
> *printf was kind of redundant.
> PS A sidenote why I bypassed MESSAGE(..): if I used the macro, make
> would segfault as MESSAGE depends on targFmt and targPrefix being set
> to something sane (they both default to NULL -- one explicitly, the
> other implicitly because it's in the .BSS). These vars are only set in
> one section of code, but I took the easy route out to avoid
> accidentally breaking other code paths and because what I did in the
> previously attached patch was simple to implement and test.
I did not mean that you should use MESSAGE() for your purposes, but
removing existing "invocations" seems to be unnecessary.
More information about the freebsd-current