panic: share -> excl @r224632

Martin Matuska mm at FreeBSD.org
Fri Aug 5 08:43:39 UTC 2011


Patch updated.

On 05.08.2011 10:26, Kostik Belousov wrote:
> On Fri, Aug 05, 2011 at 10:18:49AM +0200, Martin Matuska wrote:
>> I agree to Kostik's  approach, but I suggest implementing it in a
>> separate function and also use for the unmount() part.
>>
>> Please review attached patch.
> Since you are moving the fragment to a function, you may somewhat reduce
> the code duplication by moving at least free() and return to the end
> of function and jumping to it.
>
> Also, after more looking at this, I think now that the check for VI_DOOMED
> is not needed, due to relookup and comparision of vp and vp1.

-- 
Martin Matuska
FreeBSD committer
http://blog.vx.sk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vfs_mount.c.patch
Type: text/x-patch
Size: 3884 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20110805/1b0ad377/vfs_mount.c-0001.bin


More information about the freebsd-current mailing list