MAXCPU preparations

Julian Elischer julian at freebsd.org
Mon Sep 27 15:53:07 UTC 2010


  On 9/27/10 8:26 AM, Sean Bruno wrote:
> Does this look like an appropriate modification to libmemstat?
>
> Sean
>
>
> ==== //depot/yahoo/ybsd_7/src/lib/libmemstat/memstat.h#4
> - /home/seanbru/ybsd_7/src/lib/libmemstat/memstat.h ====
> @@ -28,12 +28,13 @@
>
>   #ifndef _MEMSTAT_H_
>   #define        _MEMSTAT_H_
> +#include<sys/param.h>
>
>   /*
>    * Number of CPU slots in library-internal data structures.  This
> should be
>    * at least the value of MAXCPU from param.h.
>    */
> -#define        MEMSTAT_MAXCPU  64
> +#define        MEMSTAT_MAXCPU  MAXCPU /* defined in
> sys/${ARCH}/include/param.h */
>


wouldn't it be better to do a sysctlbyname() and use the real value 
for the system?

>   /*
>    * Amount of caller data to maintain for each caller data slot.
> Applications
>
>
> _______________________________________________
> freebsd-current at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
>



More information about the freebsd-current mailing list