old references to vfs_mountroot_try()
Marcel Moolenaar
xcllnt at mac.com
Fri Nov 19 17:09:13 UTC 2010
On Nov 19, 2010, at 2:09 AM, Sergey Kandaurov wrote:
> On 19 November 2010 02:14, Alexander Best <arundel at freebsd.org> wrote:
>> hi there,
>>
>> vfs_mountroot_try() seems to have been removed, yet the src still contains
>> three references to it:
>>
>> vfs_mount.c:386
>> vfs_mount.c:723
>> freebsd32_misc.c:2368
>>
>
> So, what about just to rename those comments to reflect function name change?
>
> Index: sys/kern/vfs_mount.c
> ===================================================================
> --- sys/kern/vfs_mount.c (revision 215516)
> +++ sys/kern/vfs_mount.c (working copy)
> @@ -383,7 +383,7 @@
> * Filter out MNT_ROOTFS. We do not want clients of nmount() in
> * userspace to set this flag, but we must filter it out if we want
> * MNT_UPDATE on the root file system to work.
> - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
> + * MNT_ROOTFS should only be set in the kernel in parse_mount().
> */
> uap->flags &= ~MNT_ROOTFS;
>
Keep it vague. Just change the line to "MNT_ROOTFS should only be
set by the kernel when mounting its root file system".
The parse_mount() function name has no meaning other than within
sys/kern/vfs_mountroot.c, so referring to it isn't making things
clear.
FYI,
--
Marcel Moolenaar
xcllnt at mac.com
More information about the freebsd-current
mailing list