net.link.log_link_state_change broken?

[Paul B Mahol]

On 11/18/10, Bjoern A. Zeeb <bzeeb-lists at lists.zabbadoz.net> wrote:
> On Tue, 2 Nov 2010, Paul B Mahol wrote:
>
> Hi,
>
>> It appears we do not log such events anymore (at least with wlan
>> devices) in console.
>>
>> I set this sysctl to 0 via sysctl.conf, if I set it to 1, nothing will
>> change.
>>
>> Because I had loging disabled for very long time I encountered this
>> problem just now.
>
> not sure.  Might be, might not be.  Have you further looked into this?
>
> I at least see:
> ./net80211/ieee80211_freebsd.c:         if_link_state_change(ifp,
> LINK_STATE_UP);
> ./net80211/ieee80211_freebsd.c:         if_link_state_change(ifp,
> LINK_STATE_DOWN);

That part is not problematic, klog part is.

Messages of link state changes are not available in console but are
available in klog and in console once you open it with cat.

Reading comment it appears that logic is inverted in code.