unzip in basesystem.

[Rob Farmer]

On Wed, May 5, 2010 at 2:30 AM, David DEMELIER <demelier.david at gmail.com> wrote:
> 2010/5/5 David DEMELIER <demelier.david at gmail.com>:
>> Hi,
>>
>> I noticed that unzip came into basesystem in src/usr.bin/unzip/. To
>> prevent port installing the ports/archivers/unzip one, I propose to
>> add this in bsd.port.mk

Unfortunately there are some problems with the base system unzip that
make it preferable to use the port. From the commit log for
bsd.port.mk:

  9-CURRENT introduced unzip command to the base system.  Unfortunately it is
  not fully compatible with the archivers/unzip implementation and non-trivial
  amount of ports fail to build when using it.  Thus we will keep using
  archivers/unzip for unzipping source in Ports Collection until someone
  volunteer to fix all individual ports.  Two most common problems with base
  unzip are:
  * extracting files without +x flag (some ports rely to execute unzipped
    configure scripts, for example)
  * different semantics of CR/LF conversion

  Error logs of failed port builds with in-base unzip can be made available on
  request to portmgr at .

With hat:	portmgr

-- 
Rob Farmer

>>
>> .if defined(USE_ZIP) && !exists(/usr/bin/unzip)
>> EXTRACT_DEPENDS+=       ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip
>> .endif
>>
>> Is that right ?
>>
>
> Sorry I gone too fast, I would add this in bsd.commands.mk too :
>
> .if exists(/usr/bin/unzip)
> UNZIP_CMD=/usr/bin/unzip
> .else
> UNZIP_CMD?=     ${LOCALBASE}/bin/unzip
> .endif
>
> --
> Demelier David
> _______________________________________________
> freebsd-current at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
>