Official request: Please make GNU grep the default
adrian at freebsd.org
Fri Aug 20 12:36:29 UTC 2010
2010/8/20 Dag-Erling Smørgrav <des at des.no>:
> Adrian Chadd <adrian at freebsd.org> writes:
>> I've just looked at grep_fgetln(). Surely memchr() isn't required there.
> Of course it is, how else are you going to locate the '\n'? OTOH, I'm
> not sure grep_fgetln() is needed at all.
It seems a bit strange that memchr(), which should be hitting data
that's in the cache (as it was recently read, right?) is showing up so
high in the profiling results. memchr() in libc/string/memchr.c looks
like how I'd inline it, so, hm.
Have you tried this in pmc?
More information about the freebsd-current