core dump on kldload atapicam

[Warren Block]

On Tue, 22 Sep 2009, Jaakko Heinonen wrote:

> On 2009-09-21, Warren Block wrote:
>>>> I can confirm that .. kldload atapicam still results in a "Fatal trap 12:
>>>> page fault while in kernel mode" on 8.0-RC1
>
> The problem was introduced in r195534. Does the following patch work for
> you?
>
> %%%
> Index: sys/dev/ata/atapi-cam.c
> ===================================================================
> --- sys/dev/ata/atapi-cam.c	(revision 197399)
> +++ sys/dev/ata/atapi-cam.c	(working copy)
> @@ -418,8 +418,10 @@ atapi_action(struct cam_sim *sim, union
> 		break;
> 	    }
> 	}
> -	cpi->maxio = softc->ata_ch->dma.max_iosize ?
> -	    softc->ata_ch->dma.max_iosize : DFLTPHYS;
> +	if (softc->ata_ch != NULL && softc->ata_ch->dma.max_iosize != 0)
> +	    cpi->maxio = softc->ata_ch->dma.max_iosize;
> +	else
> +	    cpi->maxio = DFLTPHYS;
> 	ccb->ccb_h.status = CAM_REQ_CMP;
> 	xpt_done(ccb);
> 	return;
> %%%

Yes!  kldload atapicam is fine, as is loading it in /boot/loader.conf. 
Thank you.

-Warren Block * Rapid City, South Dakota USA