[PATCH]: if (cond); foo() in firewire

[Roman Divacky]

hi

is this patch correct? may I commit it?

Index: ../../../dev/firewire/fwdev.c
===================================================================
--- ../../../dev/firewire/fwdev.c       (revision 194573)
+++ ../../../dev/firewire/fwdev.c       (working copy)
@@ -443,7 +443,7 @@
        xfer->send.pay_len = uio->uio_resid;
        if (uio->uio_resid > 0) {
                if ((err = uiomove((caddr_t)&xfer->send.payload[0],
-                   uio->uio_resid, uio)));
+                   uio->uio_resid, uio)))
                        goto out;
        }
 

another bug found by the "useless warnings in clang" ;)

roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20090621/5dfc14d1/attachment.pgp