Patch for bin/54446

insomniac insomniac at slackware.it
Tue Nov 25 18:54:26 PST 2008


Hi to everyone,
I wrote a patch for the bin/54446 PR, fixing pkg_delete(1) that doesn't
honour symlinks, and portupgrades leads to failing services.

Actually, this patch fixes that for all the utilities as it acts
directly in the lib.

I tested the patch on a few x86 machines, ranging from 7.0 to -HEAD.
Testing and further reviewing are welcome and encouraged.

pkg_delete now seems to work fine; moreover I found other bugs, like
memory leaks, missing checks of function return values, and wrong return
values.

The patch has already been reviewed by attilio@ , it applies to
src/usr.sbin/pkg_install/lib/plist.c and is located at

http://insomniac.slackware.it/plist.c.diff

Best regards,
-- 
Andrea Barberio

a.barberio at oltrelinux.com - Linux&C.
andrea.barberio at slackware.it - Slackware Linux Project Italia
GPG key on http://insomniac.slackware.it/gpgkey.asc
2818 A961 D6D8 1A8C 6E84  6181 5FA6 03B2 E68A 0B7D
SIP: 5327786, Phone: 06 916503784
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20081126/fb744778/signature.pgp


More information about the freebsd-current mailing list