non-functional backout for review

Nathan Lay nslay at comcast.net
Wed Oct 31 20:57:41 PDT 2007


Andrey Chernov wrote:
> Some people complaints that new check in __isctype() is not human readable 
> and requests for backout. Compiler gives almost identical code for old and 
> new excepting non-optimized case where non-human readable one wins. I am a 
> bit tired to change it forth and back, so ask for final consensus here.
>
> Old one
>
> return (_c < 0 || _c >= 128) ? 0 :
>
> New one (requests for backout)
>
> return (_c & ~0x7F) ? 0 :
>
>   
Why not just comment out the old version just above the new version?

Best Regards,
Nathan Lay


More information about the freebsd-current mailing list