Broken su in current - trying to fix myself, help needed!

[David O'Brien]

On Thu, Oct 18, 2007 at 05:36:15AM +1000, Peter Jeremy wrote:
> This bug (or another one with identical symptoms) affects the 'su'
> commands within the ports build system if you are using tcsh or zsh

or bash

It has been suggested that reverting rev 1.79 of su.c may address the issue.

----------------------------
revision 1.79
date: 2006/01/03 09:17:04;  author: brian;  state: Exp;  lines: +14 -1
Fix the other su bug reintroduced two commits ago, namely

    $ su
    % kill -STOP $$

where su is executing (t)csh.  csh's job handling is a little more
special than that of (a)sh, bash and even zsh and blows up a little
more spectacularly.  This modification restores the original mucking
about with the tty pgrp, but is careful to only do it when su (or
su's child) is the foreground process
----------------------------
-- 
-- David  (obrien at FreeBSD.org)
Q: Because it reverses the logical flow of conversation.
A: Why is top-posting (putting a reply at the top of the message) frowned upon?
Let's not play "Jeopardy-style quoting"