[RFC, PATCH] Getting rid of direct calls to keyboard's methods via
kbdsw[] array
Wojciech A. Koszek
wkoszek at freebsd.org
Fri Dec 21 19:12:38 PST 2007
Hello,
In the FreeBSD kernel we have notion of keyboard represented by
"keyboard_t" type. We operate on such structures throught another
keyboard_switch structure. It lets us to use keyboard API without
distinguishing exactly which hardware we're working with.
My proposal is to unify a way in which we call such specialized
methods, so that instead of direct array indexing used to call specific
keyboard method:
(*kbdsw[(kbd)->kb_index]->enable)((kbd))
We would use unified interface:
kbdd_enable(kbd)
Proposed patch is here:
http://people.freebsd.org/~wkoszek/patches/tty/kbdcleanup.patch
Suggestions are welcome.
Thanks,
--
Wojciech A. Koszek
wkoszek at FreeBSD.org
http://FreeBSD.czest.pl/dunstan/
More information about the freebsd-current
mailing list