Linux-flashplugin7 & rtld - RFC
John Baldwin
jhb at freebsd.org
Tue Jun 20 21:07:26 UTC 2006
On Tuesday 20 June 2006 16:07, Dmitry Pryanishnikov wrote:
>
> Hello!
>
> On Tue, 20 Jun 2006, John Baldwin wrote:
> >>> This patch is somewhat redundant. Adding
> >>>
> >>> __weak_reference(dlsym, _dlsym);
> >>>
> >>> is enough.
> >>
> >> Indeed, this also works for me. It would be nice to see this trivial
> >> addition committed.
> >
> > I agree. Do you have the __weak_reference() patch handy?
>
> Sure, here is the diff against HEAD:
>
> --- libexec/rtld-elf/rtld.c.orig Tue Mar 28 10:17:21 2006
> +++ libexec/rtld-elf/rtld.c Tue Jun 20 22:35:17 2006
> @@ -137,6 +137,8 @@
>
> void r_debug_state(struct r_debug*, struct link_map*);
>
> +__weak_reference(dlsym, _dlsym);
> +
> /*
> * Data declarations.
> */
>
> I'm not sure whether it's style(9)-compliant, it just works.
Well, this patch was shot down. Would it be possible to have the
pluginwrapper provide the _dlsym weak reference itself?
--
John Baldwin
More information about the freebsd-current
mailing list