[PATCH] Fix off-by-one bug in ifconfig's af_link.c

Rong-En Fan grafan at gmail.com
Mon Jan 16 06:46:56 PST 2006


On 1/16/06, Ruslan Ermilov <ru at freebsd.org> wrote:
> On Sun, Jan 15, 2006 at 07:29:41PM +0100, Ulrich Spoerlein wrote:
> > Ulrich Sp?rlein wrote:
> > > I'm pretty sure it's the link_getaddr in af_link.c, there are two
> > > possible fixes, depending on the requirements of link_addr()
> > >
> > > If link_addr *needs* a terminating '\0', then we need to
> > > malloc(strlen(addr) + 2), if it doesn't need the terminating zero, we
> > > should get away with strncpy(temp + 1, addr, strlen(addr))
> >
> > Yeah, seems to be a slow sunday today. Attached is the fix for this
> > off-by-one bug.
> >
> Committed, thanks!

Thanks! This fixed my problem.

rafan.


More information about the freebsd-current mailing list