[RELENG_6] NFS panic on locking against myself

Xin LI delphij at frontfree.net
Fri Oct 28 12:29:09 PDT 2005


On Fri, Oct 28, 2005 at 10:22:49AM -0700, Mohan Srinivasan wrote:
> I saw this once too. The following change should fix this.
> 
> @@ -965,7 +969,7 @@
>  nfsmout:
>         if (error) {
>                 if (newvp != NULLVP) {
> -                       vrele(newvp);
> +                       vput(newvp);
>                         *vpp = NULLVP;
>                 }
>                 if ((cnp->cn_nameiop == CREATE || cnp->cn_nameiop == RENAME) &&
> 
> Will check it into current soon.

Ah!!  Thanks for this, without your confirm I was still thinking about
whether it's appropriate to replace the vrele() with vput()...

To re@:  Could we wait for some day to settle this change?

Cheers,
-- 
Xin LI <delphij frontfree net>	http://www.delphij.net/
See complete headers for GPG key and other information.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20051029/d45efc8a/attachment.bin


More information about the freebsd-current mailing list