FW: pmtu patch
Andre Oppermann
andre at freebsd.org
Mon May 2 07:48:34 PDT 2005
Qing Li wrote:
> -----Original Message-----
> From: Qing Li [mailto:qingli at FreeBSD.org]
> Sent: Thursday, April 28, 2005 5:36 PM
> To: andre at freebsd.org
> Cc: qingli at freebsd.org
> Subject: pmtu patch
>
> Hi Andre,
>
> I was thinking whether we could add another variable
> in "hc_metrics" called "u_long rmx_mtu_lastupdate" and
> perhaps a new function called "tcp_hc_getmtu_update"
>
> When we get the ICMP PRC_MSGSIZE notification, we do
>
> if (((time_second() - tcp_hc_getmtu_update(&inc)) < PMTU_MIN)
> do_nothing;
> else {
> ...
> }
>
> If there is no suggested mtu value, instead of immediately
> falling back to the default, or rely on the original
> packet fragment, can we just use the mtu value in the
> host cache as the basis for the next try as in:
>
> else {
>
> <set new value for rmx_mtu_lastupdate>
>
> mtu = ip_next_mtu(tcp_hc_getmtu(&inc), 1);
>
> }
IMO this is too complicated for too little actual value. It's not
that we are supposed to run into this problem all the time. David's
idea provides a very easy way to work around the problem without
requiring any state tracking.
--
Andre
More information about the freebsd-current
mailing list