panic in altq

Divacky Roman xdivac02 at stud.fit.vutbr.cz
Mon Feb 21 15:47:43 GMT 2005


hi,

I was seeing panics on boot when pf was enabled.
this patch:

Index: altq_subr.c
===================================================================
RCS file: /home/ncvs/src/sys/contrib/altq/altq/altq_subr.c,v
retrieving revision 1.5
diff -u -r1.5 altq_subr.c
--- altq_subr.c	15 Jun 2004 23:59:37 -0000	1.5
+++ altq_subr.c	21 Feb 2005 15:44:21 -0000
@@ -93,7 +93,7 @@
 int (*altq_input)(struct mbuf *, int) = NULL;
 static struct mbuf *tbr_dequeue(struct ifaltq *, int);
 static int tbr_timer = 0;	/* token bucket regulator timer */
-static struct callout tbr_callout = CALLOUT_INITIALIZER;
+static struct callout tbr_callout;
 
 #ifdef ALTQ3_CLFIER_COMPAT
 static int 	extract_ports4(struct mbuf *, struct ip *, struct flowinfo_in *);
@@ -155,6 +155,7 @@
 	void *(*classify)(void *, struct mbuf *, int);
 {
 	IFQ_LOCK(ifq);
+	callout_init(&tbr_callout, 0);
 	if (!ALTQ_IS_READY(ifq)) {
 		IFQ_UNLOCK(ifq);
 		return ENXIO;


it completly solves (it used illegaly initialized callout, dunno hows possible
it worked before)

I hope for commiting this

roman


More information about the freebsd-current mailing list