We have a lot of duplicated code in the kernel

[Alexander Leidinger]

Roman Kurakin <rik at cronyx.ru> wrote:

>> I've filtered the list for some false positives (twa_fwimg, trlld?m,
>> if_patm_rtables), if someone else notices some more files please tell me
>> about them and I add them to the filter.
>>
> For example if_ct.c and if_cp.c. They have to have the same code since
> they written by the same authors, and both devices have almost the same
> architecture. If I remove or would use the same prefix for DDK of both
> adapters, I am sure, code would have more than 50% of the same code. ;-)

And we can't put the common code into another file which either gets included
(in case of macros), or linked (in case of functions) to the files in
question?

Bye,
Alexander.

-- 
http://www.Leidinger.net  Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org     netchild @ FreeBSD.org  : PGP ID = 72077137
Your object is to save the world,
while still leading a pleasant life.