bin/72138: libc.so.5 isn't installed in a safe way
Ruslan Ermilov
ru at FreeBSD.org
Tue Sep 28 00:18:10 PDT 2004
Hi Xin and Matthias,
On Tue, Sep 28, 2004 at 12:33:51PM +0800, Xin LI wrote:
> (-CURRENT is cc'ed for a boarder review)
>
> I fell like this idea, and here is the patch for review:
>
> Index: Makefile
> ===================================================================
> RCS file: /r/ncvs/src/lib/libc/Makefile,v
> retrieving revision 1.52
> diff -u -r1.52 Makefile
> --- Makefile 14 May 2004 12:04:29 -0000 1.52
> +++ Makefile 28 Sep 2004 04:30:26 -0000
> @@ -16,6 +16,7 @@
> CFLAGS+=-I${.CURDIR}/include -I${.CURDIR}/../../include
> CFLAGS+=-I${.CURDIR}/${MACHINE_ARCH}
> CLEANFILES+=tags
> +SHLINSTALLFLAGS+= -S
> INSTALL_PIC_ARCHIVE= yes
> PRECIOUSLIB= yes
>
I like the idea so much, that I suggest this instead:
%%%
Index: bsd.lib.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.lib.mk,v
retrieving revision 1.160
diff -u -r1.160 bsd.lib.mk
--- bsd.lib.mk 7 May 2004 09:58:36 -0000 1.160
+++ bsd.lib.mk 28 Sep 2004 07:13:18 -0000
@@ -187,9 +187,12 @@
.if !target(install)
-.if defined(PRECIOUSLIB) && !defined(NOFSCHG)
+.if defined(PRECIOUSLIB)
+.if !defined(NOFSCHG)
SHLINSTALLFLAGS+= -fschg
.endif
+SHLINSTALLFLAGS+= -S
+.endif
_INSTALLFLAGS:= ${INSTALLFLAGS}
.for ie in ${INSTALLFLAGS_EDIT}
%%%
If you like it, please feel free to commit.
Cheers,
--
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20040928/4720519b/attachment.bin
More information about the freebsd-current
mailing list