[TEST] make -j patch [take 2]

Harti Brandt harti at freebsd.org
Fri Nov 12 07:01:22 PST 2004


On Fri, 12 Nov 2004, Poul-Henning Kamp wrote:

PK>In message <1100269107.4194c6330d578 at netchild.homeip.net>, Alexander at Leidinger.
PK>net writes:
PK>>Zitat von Poul-Henning Kamp <phk at phk.freebsd.dk>:
PK>>
PK>>> At the very least, do not commit your patch until you have managed
PK>>> to come up with at least one instance of real world data where it
PK>>> is a good idea.
PK>>
PK>>I followed the discussion so far, but I may have failed to see the obvious...
PK>>
PK>>What happens if "make -j X" runs in a situation where portupgrade gets
PK>>called (e.g. a Makefile which runs some portupgrades in parallel for
PK>>a set of ports (without overlapping in the dependency graph))?
PK>>
PK>>I assume from the discussion that the make which gets invoked by
PK>>portupgrade (without -j) will connect to the FIFO and attempt to build
PK>>some targets in parallel. Is this correct?
PK>>
PK>>If yes: we have some ports which aren't -j safe, so this would violate
PK>>POLA.
PK>
PK>That is what "make -B" is for.

Or .NOTPARALLEL

harti


More information about the freebsd-current mailing list