bsdtar breakage ?

[Tim Kientzle]

Poul-Henning Kamp wrote:
> i386 -current buildworld:
> 
> ===> gnu/usr.bin/tar (all)
> /bang/src1/src/gnu/usr.bin/tar/../../../contrib/tar/src/create.c: In function `mode_to_chars':
> /bang/src1/src/gnu/usr.bin/tar/../../../contrib/tar/src/create.c:264: warning: comparison is always false due to limited range of data type
> ===> gnu/usr.bin/tar/doc (all)
> ===> gnu/usr.bin/texinfo (all)

This is gtar.

The relevant code here is:
     mode_t v;
     int negative;
     negative = v < 0;

Since mode_t is unsigned, the comparison
"v < 0" is always false, hence the warning.

This file hasn't been touched in over two years.
mode_t has been unsigned for at least that long.

I smell a compiler upgrade.  ;-)

Tim