[UFS] Broken suiddir? (+patch)

[Pawel Jakub Dawidek]

On Wed, Mar 24, 2004 at 11:53:18PM +0100, Pawel Jakub Dawidek wrote:
+> On Tue, Mar 23, 2004 at 11:30:20PM +0100, Rafal Skoczylas wrote:
+> +> root at hawaje:/usr/src/sys/ufs/ufs% diff -u ufs_vnops.c.orig ufs_vnops.c
+> +> --- ufs_vnops.c.orig    Sat Oct 18 16:10:27 2003
+> +> +++ ufs_vnops.c Sun Mar 21 01:31:04 2004
+> +> @@ -1411,7 +1411,7 @@
+> +>                                  * our context so a stack variable is ok.
+> +>                                  */
+> +>                                 ucred.cr_ref = 1;
+> +> -                               ucred.cr_uid = ip->i_uid;
+> +> +                               ucred.cr_uid = dp->i_uid;
+> +>                                 ucred.cr_ngroups = 1;
+> +>                                 ucred.cr_groups[0] = dp->i_gid;
+> +>                                 ucp = &ucred;
+> +> root at hawaje:/usr/src/sys/ufs/ufs%
+> 
+> I haven't test your report and patch yet, but it is strange.
+> In line 1403 stays:
+> 
+> 	ip->i_uid = dp->i_uid;
+> 
+> So ip->i_uid should be equal in line which you have patched.

s/should be equal/should be equal to dp->i_uid/

-- 
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd at FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20040324/8a212d2c/attachment.bin