Giant not owned in gbincore()

Bruce Evans bde at zeta.org.au
Sat Mar 20 16:11:42 PST 2004


On Sat, 20 Mar 2004, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote:

> running America's Army 2.0.0a under ktrace results in the following
> panic:
> ...
> exit1+0x47a
> 0xc04920a6 is in exit1 (/usr/src/sys/kern/kern_exit.c:371).
> 366=09=09tracecred =3D p->p_tracecred;
> 367=09=09p->p_tracecred =3D NULL;
> 368=09=09mtx_unlock(&ktrace_mtx);
> 369=09=09PROC_UNLOCK(p);
> 370=09=09if (tracevp !=3D NULL)
> 371=09=09=09vrele(tracevp);
> 372=09=09if (tracecred !=3D NULL)
> 373=09=09=09crfree(tracecred);
> 374=09#endif

The above is not current.  This was fixed in:

% RCS file: /home/ncvs/src/sys/kern/kern_exit.c,v
% Working file: kern_exit.c
% head: 1.228
% ...
% ----------------------------
% revision 1.228
% date: 2004/03/18 18:15:58;  author: green;  state: Exp;  lines: +4 -1
% Add the missing Giant when doing anything with VFS -- in this case,
% releasing the ktrace vnode.
% ----------------------------

Bruce


More information about the freebsd-current mailing list