bug in vm_contig.c? [was: Re: ACPI crash with recent changes]

Alan Cox alc at cs.rice.edu
Thu Mar 4 20:53:06 PST 2004


On Thu, Mar 04, 2004 at 11:28:04PM -0500, Robert Watson wrote:
> 
> On Thu, 4 Mar 2004, Alan L. Cox wrote:
> 
> > Please test the attached patch instead.  In order to avoid a race
> > condition, it is necessary for the loop to begin with "start" rather
> > than "start + 1".  What is both unnecessary and wrong is the physical
> > contiguity check.  (My bad. :-()  In other words, the test that the page
> > is still free must be repeated because of the dropping of the free page
> > queue lock, but contiguity once true is always true. 
> 
> Using this patch, my testbox boots just fine.
> 

Thanks.  I've committed the patch.

Alan


More information about the freebsd-current mailing list