fix for libpthread

David Xu davidxu at freebsd.org
Wed Mar 3 00:09:59 PST 2004


Alfred Perlstein wrote:

>This assertion doesn't seem necessary.  Apply to 
>src/lib/libpthread/thread/thr_spinlock.c
>
>
>cvs server: Diffing .
>Index: thr_spinlock.c
>===================================================================
>RCS file: /home/ncvs/src/lib/libpthread/thread/thr_spinlock.c,v
>retrieving revision 1.21
>diff -u -r1.21 thr_spinlock.c
>--- thr_spinlock.c	9 Dec 2003 02:37:40 -0000	1.21
>+++ thr_spinlock.c	3 Mar 2004 06:10:25 -0000
>@@ -79,8 +79,6 @@
> {
> 	struct spinlock_extra *extra;
> 
>-	if (!__isthreaded)
>-		PANIC("Spinlock called when not threaded.");
> 	if (!initialized)
> 		PANIC("Spinlocks not initialized.");
> 	/*
>  
>
As I saw some reports in the -CURRENT list,  the panic is always 
triggered by mix up
of libc_r and libpthread in same program. So to avoid other mysterious 
crashes,
I'd like keep the code there, it is now used to check the problem.

David Xu




More information about the freebsd-current mailing list