boot2 patch, please test.

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Jun 2 00:55:14 PDT 2004


In message <200406011125.03166.jhb at FreeBSD.org>, John Baldwin writes:
>On Saturday 29 May 2004 05:21 pm, Poul-Henning Kamp wrote:
>> Some embedded boxes do not have the keyboard controller, and this
>> patch adds a timeout so they do not get stuck waiting for it to
>> become ready.
>>
>> Please test that this patch does not have any effect on normal
>> PC architecture machines.
>
>I'd prefer that you explicitly set %cx to a timeout value after the cli 
>instead of relying on its value being zero in the caller.

ENOMOREBYTES :-(

I guess the logical thing would be to inline it rather than have it be
a function, that saves the cx initializtion, the call and the return.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the freebsd-current mailing list