[PATCH] IPSec fixes

Jun-ichiro itojun Hagino itojun at itojun.org
Tue Jan 13 16:37:35 PST 2004


> > http://sources.zabbadoz.net/freebsd/patchset/110-ipsec-netkey-key.diff
> 	dunno if it is correct or not.  need more investigation.

	location of key_freesp() are wrong (you end up dereference freed
	pointer on ipseclog() because you call key_freesp() beforehand).
	other than that, those key_freesp() are needed.  thanks.

	as for key_sp_unlink(), i don't think the patch is correct.
	even if you do not call key_sp_unlink() in key_spdflush(), spd entries
	will get unlink'ed in key_timehandler().  therefore the end result
	will be the same.

itojun


More information about the freebsd-current mailing list