dump broken with new kernel

[Manfred Antar]

At 09:17 AM 12/6/2004, David O'Brien wrote:
>On Mon, Dec 06, 2004 at 08:01:01AM -0800, Manfred Antar wrote:
>> When I try to do a dump of the root filesystem I get :
>> 
>> mksnap_ffs: Cannot create //.snap/dump_snapshot: Invalid argument
>> dump: Cannot create //.snap/dump_snapshot: No such file or directory
>> 
>> A kernel from a week ago works fine.
>> The command I'm using is:
>> dump 0Lfua /dev/nsa0 /dev/ad0s1a
>> 
>> The .snap directory does exist and it is:
>> drwxrwx---   2 root  operator      512 Dec  6 07:52 .snap
>
>I got this over the week end as I was trying to move some file systems to
>a new disk.  By chance can you use a binary search and track it down to a
>particular day or maybe even the exact commit?
> 
>-- 
>-- David  (obrien at FreeBSD.org) 

This seems to be when the change was made:
cvs co  -D"December 3, 2004 20:00 UTC" sys  -- dump broken

cvs co  -D"December 3, 2004 18:00 UTC" sys   -- dump works

The suspect files seem to be:
sys/kern/vfs_mount.c
$FreeBSD: src/sys/kern/vfs_mount.c,v 1.156 2004/12/03 19:25:44 phk Exp

sys/sys/mount.h
$FreeBSD: src/sys/sys/mount.h,v 1.180 2004/12/03 19:33:19 phk Exp $

I know phk has been working on the mount stuff.

==================================
||      null at pozo.com           ||
||      Ph. (415) 681-6235      ||
==================================