HEADS UP: CAM error recovery change

Kenneth D. Merry ken at kdm.org
Sun Oct 26 23:14:57 PST 2003


I checked in a change to the CAM error recovery code that will hopefully
have a positive effect on systems with CDROM drives that were taking a
while to probe.

Anyway, try this out and let me know if there are any regressions.

Thanks,

Ken

----- Forwarded message from "Kenneth D. Merry" <ken at FreeBSD.org> -----

From: "Kenneth D. Merry" <ken at FreeBSD.org>
Date: Sun, 26 Oct 2003 22:15:55 -0800 (PST)
To: src-committers at FreeBSD.org, cvs-src at FreeBSD.org, cvs-all at FreeBSD.org
Subject: cvs commit: src/sys/cam cam_periph.c src/sys/cam/scsi scsi_cd.c

ken         2003/10/26 22:15:55 PST

  FreeBSD src repository

  Modified files:
    sys/cam              cam_periph.c 
    sys/cam/scsi         scsi_cd.c 
  Log:
  In camperiphdone(), make sure we check for fatal errors and bail out
  instead of retrying them blindly.
  
  This should fix some of the problems people have been having with cdrom
  drives taking a long time to probe.  This should also eliminate the need
  for the initial TUR in cdsize().
  
  cam_periph.c:   Don't keep retrying if the error we get back is a fatal
                  error.  This should help us detect the transition from
                  "Logical unit not ready, cause not reportable" to "Medium
                  not present" in the "TUR many" handler.  (The TUR many
                  handler gets triggered for Logical unit not ready, cause
                  not reportable errors.)
  
  scsi_cd.c:      Remove the initial test unit ready in cdsize().  Hopefully
                  it isn't necessary after the above change.
  
  Submitted by:   gibbs (mostly)
  Tested by:      peter
  MFC After:      2 weeks
  
  Revision  Changes    Path
  1.55      +17 -2     src/sys/cam/cam_periph.c
  1.88      +0 -14     src/sys/cam/scsi/scsi_cd.c

----- End forwarded message -----

-- 
Kenneth Merry
ken at kdm.org


More information about the freebsd-current mailing list