Approval for Hotfix needed for portscanner (was Re: Error assigning master socket: Too many open files)

[Andreas Klemm]

On Wed, Oct 22, 2003 at 03:30:41PM +0100, Peter Edwards wrote:
> The patch applied by the port appears bogus. It adds braces around an 
> "if" that stops it executing the way it was intended. I've a sneaking 
> suspicion that the braces were added for "clarity", but the indentation 
> in the original file is so badly off that the terminating brace was put 
> in the wrong place. Try replacing patch-ab with this:
> 
> --- portscanner.c.orig  Wed Aug 19 18:37:44 1998
> +++ portscanner.c       Wed Oct 22 15:28:05 2003
> @@ -25,8 +25,8 @@
> /***********************************************************/
> 
> #include <stdio.h>
> -#include <sys/socket.h>
> #include <sys/types.h>
> +#include <sys/socket.h>
> #include <netinet/in.h>
> #include <unistd.h>
> #include <netdb.h>

Hi Peter,

thanks a lot for your help. You're completely right with your
diagnose and fix.

I'll put portmgr@ on Cc: to be allowed to commit the change
and will happily apply your fix to the port if I get the approval.

look here:

root at titan[ttyp2]{82} /usr/ports/security/portscanner portscanner -b 1 -e 60000 -vv xx.xx.xx.xxx
Resolving: xx.xx.xx.xxx -> resolved
Current address: xx.xx.xx.xxx
Port range: 1 to 60000
Port 135 found. Service name: loc-srv
Port 445 found. Service name: microsoft-ds
Port 1025 found. Service name: blackjack

Port scan finished !

After changing the patch and reinstalling the port,
the portscanner is completely functional again now.

Best regards

	Andreas ///

-- 
Andreas Klemm - Powered by FreeBSD 5.1-CURRENT
Need a magic printfilter today ? -> http://www.apsfilter.org/