bug in big pipe code causing performance problems

Mike Silbersack silby at silby.com
Wed Jul 30 15:00:42 PDT 2003



On Wed, 30 Jul 2003, Pierre Beyssac wrote:

> On Wed, Jul 30, 2003 at 11:32:49PM +0200, Pierre Beyssac wrote:
> > -		if (space > 0 && (wpipe->pipe_buffer.cnt < PIPE_SIZE)) {
> > +		if (space > 0
> > +		    && wpipe->pipe_buffer.cnt < wpipe->pipe_buffer.size) {
>
> PS : not-so-obvious after all since the above is equivalent to
> "(space > 0)" by itself, so I won't commit the above as is, and the
> real fix might be something more complicated...
> --
> Pierre Beyssac	      	    pb at fasterix.frmug.org pb at fasterix.freenix.org
>     Free domains: http://www.eu.org/ or mail dns-manager at EU.org

Good timing. :)

I was just writing a reply which stated that (space > 0) would be
sufficient.  However, as you point out, there might be something subtle
lurking around.  I'll do some doublechecking tonight and get back to you.

Mike "Silby" Silbersack


More information about the freebsd-current mailing list