Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins

[Jacques A. Vidrine]

On Wed, Jul 23, 2003 at 01:57:56AM +0200, Simon Barner wrote:
> > > --- plugins/check_by_ssh.c.orig	Mon Apr 23 09:43:11 2001
> > > +++ plugins/check_by_ssh.c	Tue Jul 22 05:05:52 2003
> > > @@ -191,7 +191,7 @@
> > >  	if (commands>1)
> > >  		remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;");
> > >  
> > > -	if (strlen (remotecmd) <= 1)
> > > +	if (remotecmd==NULL)
> > >  		usage ("No remotecmd\n");
> > >  
> > >  	comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);
> > 
> > This looks like more than a fix for a `compile failure'.  The
> > replacement code has different semantics than the new code.
> > What is the `compile failure' that was being fixed here?
> 
> I don't know, either. This patch was part of the port before I touched
> it [1]. 

Oh, well nevermind!  I thought this was a new patch to deal with
`compile failures'.  Cheers!

> Perhaps one should write
> 
> if ((remotecmd==NULL) || (strlen (remotecmd) <= 1))
> 
> to be on the safe side?

Maybe.  The original submittor might recall.

Cheers,
-- 
Jacques Vidrine   . NTT/Verio SME      . FreeBSD UNIX       . Heimdal
nectar at celabo.org . jvidrine at verio.net . nectar at freebsd.org . nectar at kth.se