Fix for rman [was: Re: [-CURRENT tinderbox] ...]

[Marcel Moolenaar]

On Tue, Jul 15, 2003 at 10:16:01PM -0700, Kris Kennaway wrote:
> > 
> > malloc, you say? I have build failures in XFree4-clients because
> > rman coredumps and I have a backtrace full of free() frames...
> > 
> > Coincidence?
> 
> Some of the XFree86 utilities contain malloc bugs..rman in particular
> has been dumping core on certain ports for a couple of years.  I tried
> to track it down once but couldn't find it.

[cc anholt@]

The attached patch fixes rman. The faulting case is "\\\0". The '\0'
was handled in the default case for escaped characters, which also
incremented the pointer p beyond the terminating '\0'. 

Oh: this goes to devel/imake-4 of course.

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel at xcllnt.net
-------------- next part --------------
--- ../extras/rman/rman.c.orig	Tue Jul 15 23:53:53 2003
+++ ../extras/rman/rman.c	Tue Jul 15 23:44:21 2003
@@ -4104,6 +4104,9 @@
 	     }
 	   }
 	   break;
+	 case 0:
+	   /* ignore */
+	   break;
 	 default:		/* unknown escaped character */
 	   sputchar(*p++);
 	 }