[patch] minor Makefile cleanups

Alexey Dokuchaev danfe at nsu.ru
Tue Nov 1 03:51:59 UTC 2011


please consider attached diff:

- checking nss version to be >=3.12 is probably long overdue; it was
  updated to version 3.12.4 back in 2009/09/08 (more than two years ago)

- prefer official spellings for Clang and GCC; use the word "build"
  instead of "compile" as it is more appropriate in this case

./danfe
-------------- next part --------------
Index: Makefile
===================================================================
RCS file: /home/danfe/fbsd/FreeBSD-CVS/ports/www/chromium/Makefile,v
retrieving revision 1.56
diff -u -r1.56 Makefile
--- Makefile	27 Oct 2011 11:00:46 -0000	1.56
+++ Makefile	1 Nov 2011 03:15:30 -0000
@@ -25,9 +25,7 @@
 		bash:${PORTSDIR}/shells/bash \
 		yasm:${PORTSDIR}/devel/yasm \
 		flock:${PORTSDIR}/sysutils/flock \
-		v4l_compat>=1.0.20110603:${PORTSDIR}/multimedia/v4l_compat \
-		nss>=3.12:${PORTSDIR}/security/nss
-# minimal version of nss, LIB_DEPENDS does not enforce this
+		v4l_compat>=1.0.20110603:${PORTSDIR}/multimedia/v4l_compat
 
 LIB_DEPENDS=	execinfo.1:${PORTSDIR}/devel/libexecinfo \
 		cairo.2:${PORTSDIR}/graphics/cairo \
@@ -80,8 +78,8 @@
 OPTIONS=	CODECS	"Compile and enable patented codecs like H.264"	on \
 		GCONF	"Use GConf2 for preferences"			on \
 		PULSE	"Enable Pulse Audio support"			off \
-		CLANG	"Compile Chromium with clang"			off \
-		GCC45	"Compile Chromium with gcc 4.5+"		off \
+		CLANG	"Build Chromium with Clang"			off \
+		GCC45	"Build Chromium with GCC 4.5+"			off \
 		DEBUG	"Compile with debug symbols and verbose output"	off
 
 .include <bsd.port.options.mk>


More information about the freebsd-chromium mailing list