conf/188109: [patch] ASSERTION FAILED running individual periodic scripts on 10/11 branches

[Jason Unovitch]

>Number:         188109
>Category:       conf
>Synopsis:       [patch] ASSERTION FAILED running individual periodic scripts on 10/11 branches
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 31 03:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jason Unovitch
>Release:        10.0-RELEASE
>Organization:
N/A
>Environment:
FreeBSD xts-bsd 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root at snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
r254974 introduced the ability to run security periodic scripts on a daily/weekly/monthly basis.  It also introduced an assumption that the $PERIODIC variable exported on line 81 /usr/sbin/periodic would be defined.  This introduces a minor regression as we cannot run individual scripts by running directly from a shell anymore.
>How-To-Repeat:
cd /etc/periodic/security
./100.chksetuid

ASSERTION FAILED: Unexpected value for  $PERIODIC: ''
>Fix:
Workaround:
env PERIODIC=security ./100.chksetuid

Fix:
Apply attached patch to provide an extra case statement entry for an empty $PERIODIC variable.

Patch attached with submission follows:

Index: periodic.conf
===================================================================
--- periodic.conf	(revision 263916)
+++ periodic.conf	(working copy)
@@ -360,6 +360,10 @@
 			*) return 0 ;;
 			esac
 			;;
+		'')
+			# Run individual scripts from shell
+			return 0
+			;;
 		*)
 			echo "ASSERTION FAILED: Unexpected value for " \
 			    "\$PERIODIC: '$PERIODIC'" >&2


>Release-Note:
>Audit-Trail:
>Unformatted: