misc/186915: ports-mgmt/portmaster: tries to use pkg to resolve missing dependency issue

[kaltheat]

>Number:         186915
>Category:       misc
>Synopsis:       ports-mgmt/portmaster: tries to use pkg to resolve missing dependency issue
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 20 11:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     kaltheat
>Release:        FreeBSD-10.0-RELEASE
>Organization:
>Environment:
>Description:
Hi,

I recently realized that portmaster is slightly misbehaving when checking-dependencies. I did:
portmaster --check-depends

Because I have no pkg repo enabled I got a message of pkg at the end that no repo is configured.

To me it made no sense that I need an enabled repo to check dependencies so I crawled through source of portmaster and saw that pkg utility is used to check if there is a dependecy failure, but it used with wrong set of parameters, so pkg tries to resolve the error.



Regards,
kaltheat
>How-To-Repeat:

>Fix:
Here's a patch to avoid this behaviour:

--- portmaster.ori      2014-02-17 21:03:12.549866000 +0000
+++ portmaster  2014-02-20 11:50:19.343070138 +0000
@@ -1590,7 +1590,8 @@
 if [ -n "$CHECK_DEPENDS" ]; then
        if [ -n "$use_pkgng" ]; then
                # TODO
-               pkg check -adv
+               echo "Missing dependencies:"
+               pkg check -adn
                exit
        fi
        PM_VERBOSE=pmv_check_depends


>Release-Note:
>Audit-Trail:
>Unformatted: