kern/175674: commit references a PR

[dfilter service]

The following reply was made to PR kern/175674; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/175674: commit references a PR
Date: Sat, 16 Feb 2013 06:07:16 +0000 (UTC)

 Author: davidxu
 Date: Sat Feb 16 06:07:07 2013
 New Revision: 246872
 URL: http://svnweb.freebsd.org/changeset/base/246872
 
 Log:
   Simplify code by using flag O_EXLOCK.
   
   PR: kern/175674
 
 Modified:
   head/lib/libc/gen/sem_new.c
 
 Modified: head/lib/libc/gen/sem_new.c
 ==============================================================================
 --- head/lib/libc/gen/sem_new.c	Sat Feb 16 05:22:48 2013	(r246871)
 +++ head/lib/libc/gen/sem_new.c	Sat Feb 16 06:07:07 2013	(r246872)
 @@ -198,15 +198,11 @@ _sem_open(const char *name, int flags, .
  		goto error;
  	}
  
 -	fd = _open(path, flags|O_RDWR|O_CLOEXEC, mode);
 +	fd = _open(path, flags|O_RDWR|O_CLOEXEC|O_EXLOCK, mode);
  	if (fd == -1)
  		goto error;
 -	if (flock(fd, LOCK_EX) == -1)
 +	if (_fstat(fd, &sb))
  		goto error;
 -	if (_fstat(fd, &sb)) {
 -		flock(fd, LOCK_UN);
 -		goto error;
 -	}
  	if (sb.st_size < sizeof(sem_t)) {
  		sem_t tmp;
  
 @@ -214,10 +210,8 @@ _sem_open(const char *name, int flags, .
  		tmp._kern._has_waiters = 0;
  		tmp._kern._count = value;
  		tmp._kern._flags = USYNC_PROCESS_SHARED | SEM_NAMED;
 -		if (_write(fd, &tmp, sizeof(tmp)) != sizeof(tmp)) {
 -			flock(fd, LOCK_UN);
 +		if (_write(fd, &tmp, sizeof(tmp)) != sizeof(tmp))
  			goto error;
 -		}
  	}
  	flock(fd, LOCK_UN);
  	sem = (sem_t *)mmap(NULL, sizeof(sem_t), PROT_READ|PROT_WRITE,
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"