misc/175974: logic issue in ppp(8)

Fri Feb 8 23:20:00 UTC 2013

>Number:         175974
>Category:       misc
>Synopsis:       logic issue in ppp(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 08 23:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Sascha Wildner
>Release:        seen on current
>Organization:
DragonFly BSD
>Environment:
>Description:
usr.sbin/ppp/mppe.c has the following check in line 171:

if (*proto < 0x21 && *proto > 0xFA) {

My assumption is that it should be an || but I lack the MPPE clue to verify it.

Best regards,
Sascha

>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: