bin/181344: Buildworld fail at xinstall when upgrading from 9.1-STABLE

[Monkey Brains]

>Number:         181344
>Category:       bin
>Synopsis:       Buildworld fail at xinstall when upgrading from 9.1-STABLE
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 16 17:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Monkey Brains
>Release:        FreeBSD 9.1-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lavash.monkeybrains.net 9.1-STABLE FreeBSD 9.1-STABLE #6: Sat Jan 5 00:00:01 PST 2013 monkey at injera.monkeybrains.net:/usr/obj/usr/src/sys/INJERA amd64


	
>Description:
Running 'svnup stable' creates a system that cannot be built.
This bug has been around a while:
       http://lists.freebsd.org/pipermail/freebsd-current/2013-April/041410.html
       http://lists.freebsd.org/pipermail/freebsd-stable/2013-March/072981.html

A users expectation is that a minor upgrade should compile without manual
interventions.  Please fix this build issue, thank you!



>How-To-Repeat:
# cd /usr/src/usr.bin/xinstall
# rm xinstall.c
# svnup stable
# make
cc -O2 -pipe  -I/usr/src/usr.bin/xinstall/../../contrib/mtree -I/usr/src/usr.bin/xinstall/../../lib/libnetbsd -I/usr/src/usr.bin/xinstall/../../lib/libmd -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/usr.bin/xinstall/xinstall.c
cc1: warnings being treated as errors
/usr/src/usr.bin/xinstall/xinstall.c: In function 'main':
/usr/src/usr.bin/xinstall/xinstall.c:301: warning: implicit declaration of function 'gid_from_group'
/usr/src/usr.bin/xinstall/xinstall.c:301: warning: nested extern declaration of 'gid_from_group'
/usr/src/usr.bin/xinstall/xinstall.c:311: warning: implicit declaration of function 'uid_from_user'
/usr/src/usr.bin/xinstall/xinstall.c:311: warning: nested extern declaration of 'uid_from_user'
/usr/src/usr.bin/xinstall/xinstall.c: In function 'metadata_log':
/usr/src/usr.bin/xinstall/xinstall.c:1331: warning: implicit declaration of function 'strsvis'
/usr/src/usr.bin/xinstall/xinstall.c:1331: warning: nested extern declaration of 'strsvis'
*** [xinstall.o] Error code 1

	
>Fix:
	Don't know how to fix.


>Release-Note:
>Audit-Trail:
>Unformatted: