kern/168294: ixgbe driver compiled in kernel has no Flow Director support although loaded as a module has one

[Sergey Budnevitch]

>Number:         168294
>Category:       kern
>Synopsis:       ixgbe driver compiled in kernel has no Flow Director support although loaded as a module has one
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 24 07:10:03 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Sergey Budnevitch
>Release:        FreeBSD 9.0-RELEASE
>Organization:
>Environment:
FreeBSD fbsd9-amd64-ovl.xxxx.xxx 9.0-RELEASE FreeBSD 9.0-RELEASE #21: Tue May 15 10:26:20 UTC 2012     root at fbsd9-amd64-ovl.xxx.xxx:/usr/obj/usr/src/sys/D  amd64
>Description:
Flow Director support is enabled by defining IXGBE_FDIR. modules/ixgbe/Makefile 
adds -DIXGBE_FDIR to CFLAGS, so Flow Director works with ixgbe loaded as a module,
but built in kernel leave IXGBE_FDIR undefined.
>How-To-Repeat:
compile kernel with
device ixgbe
>Fix:
Coping CFLAGS from modules/ixgbe/Makefile to sys/conf/files fix the problem.

--- sys/conf/files.orig 2012-05-21 14:57:14.000000000 +0000
+++ sys/conf/files      2012-05-21 14:59:13.000000000 +0000
@@ -1366,7 +1366,7 @@
 dev/ixgb/ixgb_ee.c             optional ixgb
 dev/ixgb/ixgb_hw.c             optional ixgb
 dev/ixgbe/ixgbe.c              optional ixgbe inet \
-       compile-with "${NORMAL_C} -I$S/dev/ixgbe"
+       compile-with "${NORMAL_C} -I$S/dev/ixgbe -DSMP -DIXGBE_FDIR"
 dev/ixgbe/ixv.c                        optional ixgbe inet \
        compile-with "${NORMAL_C} -I$S/dev/ixgbe"
 dev/ixgbe/ixgbe_phy.c          optional ixgbe inet \


>Release-Note:
>Audit-Trail:
>Unformatted: