kern/168095: commit references a PR
dfilter service
dfilter at FreeBSD.ORG
Mon May 21 02:40:12 UTC 2012
The following reply was made to PR kern/168095; it has been noted by GNATS.
From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:
Subject: Re: kern/168095: commit references a PR
Date: Mon, 21 May 2012 02:30:35 +0000 (UTC)
Author: kevlo
Date: Mon May 21 02:30:22 2012
New Revision: 235711
URL: http://svn.freebsd.org/changeset/base/235711
Log:
Fix improper handling of variadic args with ICDEBUG
PR: kern/168095
Submitted by: gcooper
Modified:
head/sys/libkern/iconv.c
head/sys/sys/iconv.h
Modified: head/sys/libkern/iconv.c
==============================================================================
--- head/sys/libkern/iconv.c Mon May 21 02:23:20 2012 (r235710)
+++ head/sys/libkern/iconv.c Mon May 21 02:30:22 2012 (r235711)
@@ -549,9 +549,7 @@ int
iconv_lookupcp(char **cpp, const char *s)
{
if (cpp == NULL) {
- ICDEBUG("warning a NULL list passed\n", ""); /* XXX ISO variadic macros cannot
- leave out the
- variadic args */
+ ICDEBUG("warning a NULL list passed\n", "");
return ENOENT;
}
for (; *cpp; cpp++)
Modified: head/sys/sys/iconv.h
==============================================================================
--- head/sys/sys/iconv.h Mon May 21 02:23:20 2012 (r235710)
+++ head/sys/sys/iconv.h Mon May 21 02:30:22 2012 (r235711)
@@ -240,7 +240,7 @@ int iconv_converter_tolowerstub(int c, v
int iconv_converter_handler(module_t mod, int type, void *data);
#ifdef ICONV_DEBUG
-#define ICDEBUG(format, ...) printf("%s: "format, __func__ , __VA_ARGS__)
+#define ICDEBUG(format, ...) printf("%s: "format, __func__ , ## __VA_ARGS__)
#else
#define ICDEBUG(format, ...)
#endif
_______________________________________________
svn-src-all at freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
More information about the freebsd-bugs
mailing list