kern/166382: [patch] snd_hda(4) is in a bad state after suspend/resume cycle

[Brandon Gooch]

On Thu, Mar 29, 2012 at 2:35 AM, Alexander Motin <mav at freebsd.org> wrote:
> On 03/29/12 03:26, Brandon Gooch wrote:
>>
>> On Sat, Mar 24, 2012 at 11:22 PM,<eadler at freebsd.org>  wrote:
>>>
>>> Synopsis: [patch] snd_hda(4) is in a bad state after suspend/resume cycle
>>>
>>> Responsible-Changed-From-To: freebsd-bugs->mav
>>> Responsible-Changed-By: eadler
>>> Responsible-Changed-When: Sun Mar 25 04:22:54 UTC 2012
>>> Responsible-Changed-Why:
>>> over to maintainer
>>>
>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=166382
>>
>>
>> Hey mav, thanks for taking a look and providing a patch!
>> Unfortunately, it doesn't fix the suspend/resume issue  The headphone
>> jack sense polling doesn't work after resume unless the callback is
>> reinitialized.
>>
>> Does it hurt to reinit the callback in the case of both polling and
>> non-polling configuartions?
>
>
> Polling is always bad. It is needed only if CODEC can't send unsolicited
> responses for jack events. I think I see the real problem: unsolicited
> responses are not reconfigured on resume. Please try attached patch.
>
> --
> Alexander Motin

Yes, you're right about polling.  And, yes, this is the correct fix, thank you!

-Brandon