bin/160913: 9.0 bsdinstall unfriendly

[Joe Barbish]

>Number:         160913
>Category:       bin
>Synopsis:       9.0 bsdinstall unfriendly
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 22 16:50:12 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Joe Barbish
>Release:        9.0 beta 2
>Organization:
none
>Environment:
>Description:
bsdinstall/auto script is very user unfriendly.
1. There is no information provided for keymap function about now to
get the default used in previous releases. Added dailog about selecting the cancel button to get the default English Latin language keyboard.
2. The "finalconfig" logic defaulted to "add user". NO body wants to have to use the selection arrow to navagate to the last entry in list to exit. Changed order of options so "Exit" is the default so this dialog works just like all the other dailogs.
3. sysinstall ended with msgbox telling users to remove the install media cd/dvd/ before rebooting the new installed system. Added dailog to perform this same function.


A patch is provided.
  
>How-To-Repeat:

>Fix:
Use included patch

Patch attached with submission follows:

--- auto	2011-09-22 11:55:32.000000000 -0400
+++ auto.new	2011-09-22 12:06:37.000000000 -0400
@@ -45,6 +45,12 @@
 rm -rf $BSDINSTALL_TMPETC
 mkdir $BSDINSTALL_TMPETC
 
+dialog --backtitle "FreeBSD Installer" \
+       --title "Keyboard Localization" --msgbox \
+"You are about to exec the kbdmap command to customize Freebsd to use a \
+national language keyboard. Select the CANCEL button get the default English \
+Latin 101 keyboard used in previous releases." 0 0
+
 trap true SIGINT	# This section is optional
 bsdinstall keymap
 
@@ -156,18 +162,18 @@
     bsdinstall adduser
 
 finalconfig() {
-	exec 3>&1
+exec 3>&1
 	REVISIT=$(dialog --backtitle "FreeBSD Installer" \
 	    --title "Final Configuration" --no-cancel --menu \
 	    "Setup of your FreeBSD system is nearly complete. You can now modify your configuration choices or apply more complex changes using a shell." 0 0 0 \
+		"Exit" "Apply configuration and exit installer" \
 		"Add User" "Add a user to the system" \
 		"Root Password" "Change root password" \
 		"Hostname" "Set system hostname" \
 		"Network" "Networking configuration" \
 		"Services" "Set daemons to run on startup" \
 		"Time Zone" "Set system timezone" \
-		"Shell" "Open a shell in the new system" \
-		"Exit" "Apply configuration and exit installer" 2>&1 1>&3)
+		"Shell" "Open a shell in the new system" 2>&1 1>&3)
 	exec 3>&-
 
 	case "$REVISIT" in
@@ -221,3 +227,9 @@
 
 echo "Installation Completed at $(date)" >> $BSDINSTALL_LOG
 
+cdcontrol eject
+dialog --backtitle "FreeBSD Installer" --title "Install Completed" --msgbox \
+"Your new system is about to reboot. Remove your installation \
+media CD/DVD or USB memstick mow" 0 0
+
+


>Release-Note:
>Audit-Trail:
>Unformatted: