misc/158351: missing #includes in <cam/cam.h>

[Robert Millan]

>Number:         158351
>Category:       misc
>Synopsis:       missing #includes in <cam/cam.h>
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 27 16:30:12 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Robert Millan
>Release:        Debian GNU/kFreeBSD "sid"
>Organization:
>Environment:
>Description:
dimoni# cat > test.c
#include <cam/cam.h>
^D
dimoni# gcc -c test.c -o /dev/null 
In file included from test.c:1:
/usr/include/cam/cam.h:40: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'path_id_t'
/usr/include/cam/cam.h:41: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'target_id_t'
/usr/include/cam/cam.h:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lun_id_t'
/usr/include/cam/cam.h:78: error: expected specifier-qualifier-list before 'u_int32_t'
/usr/include/cam/cam.h:230: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cam_quirkmatch'
/usr/include/cam/cam.h:233: error: expected ')' before '*' token
/usr/include/cam/cam.h:235: error: expected ';', ',' or ')' before '*' token
/usr/include/cam/cam.h:252: error: expected declaration specifiers or '...' before 'FILE'

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- /usr/include/cam/cam.h	2011-02-19 23:06:57.000000000 +0100
+++ cam.h	2011-06-27 18:22:16.885773750 +0200
@@ -33,8 +33,11 @@
 
 #ifdef _KERNEL
 #include <opt_cam.h>
+#else
+#include <stdio.h>	/* FILE */
 #endif
 
+#include <sys/types.h>
 #include <sys/cdefs.h>
 
 typedef u_int path_id_t;


>Release-Note:
>Audit-Trail:
>Unformatted: